-
Notifications
You must be signed in to change notification settings - Fork 1.4k
applications: nrf_desktop: turn on BT_ID_AUTO_SWAP_MATCHING_BONDS #23094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 0afef3c132bd0c15993afc35350670619c7fd7ed more detailssdk-nrf:
Github labels
List of changed files detected by CI (1)Outputs:ToolchainVersion: 11ad62c2a5 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR here. |
applications/nrf_desktop/Kconfig.ble
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't imply CONFIG_BT_PRIVACY (not needed for most of the use-cases). You could simply imply BT_ID_AUTO_SWAP_MATCHING_BONDS (or conditionally overwrite default) if needed. Please also add description under Kconfig help.
btw. Can BLE peripheral without privacy also bond with the same peer on multiple BLE local identities (this use-case is relevant for nRF Desktop too)?
applications/nrf_desktop/Kconfig.ble
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whole entry can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, great I thought about it and wanted your opinion on that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to overwrite default with the same value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include reference to the Kconfig option and mention that application overwrites Kconfig default for nRF Desktop peripheral.
b76db03 to
d044228
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * The :kconfig:option:`CONFIG_BT_ID_AUTO_SWAP_MATCHING_BONDS` Kconfig option in implied options for nRF Desktop peripherals. | |
| * The :kconfig:option:`CONFIG_BT_ID_AUTO_SWAP_MATCHING_BONDS` Kconfig option as an imply for nRF Desktop peripherals. |
bd2ac83 to
03133d5
Compare
|
Add DNM as waiting for: https://github.com/zephyrproject-rtos/zephyr/pull/93821/files |
Memory footprint analysis revealed the following potential issuesapplications.nrf_desktop.zdebug.uart[nrf54lm20dk/nrf54lm20a/cpuapp]: ROM size increased by 968[B] in comparison to the main[30c6c4a] branch. - link (cc: @nrfconnect/ncs-si-bluebagel) Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-23094/12) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please describe removal of CONFIG_ BT_ID_UNPAIR_MATCHING_BONDS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1d73d30 to
9b90d7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * The :kconfig:option:`CONFIG_BT_ID_AUTO_SWAP_MATCHING_BONDS` Kconfig option as an imply for Fast Pair nRF Desktop peripherals. | |
| The option allows the application to automatically swap matching bonds when the Bluetooth local identity changes. | |
| Due to that change and change in the zephyr host smp module, the nRF Desktop application no longer requires the :kconfig:option:`CONFIG_ BT_ID_UNPAIR_MATCHING_BONDS` Kconfig option to be enabled. | |
| Removing it enables the possibility for bonding with the same HID host on multiple Bluetooth local identities for all nRF Desktop peripherals. | |
| * The :kconfig:option:`CONFIG_BT_ID_AUTO_SWAP_MATCHING_BONDS` Kconfig option as an imply to the :kconfig:option:`CONFIG_DESKTOP_BT_PERIPHERAL` Kconfig option. | |
| As a result, all nRF Desktop Fast Pair configurations have the :kconfig:option:`CONFIG_BT_ID_AUTO_SWAP_MATCHING_BONDS` Kconfig option enabled by default. | |
| The option allows the application to automatically swap matching bonds when the Bluetooth local identity changes and the Bluetooth Privacy feature (:kconfig:option:`CONFIG_BT_PRIVACY`) is enabled. | |
| Build configurations without the Bluetooth Privacy feature support the bond swapping without any dedicated Kconfig option. | |
| Due to that change and change in the SMP layer of the Zephyr Bluetooth stack, the nRF Desktop application no longer requires the :kconfig:option:`CONFIG_BT_ID_UNPAIR_MATCHING_BONDS` Kconfig option to be enabled. | |
| Removing it enables the possibility for bonding with the same HID host on multiple Bluetooth local identities for all nRF Desktop peripherals. |
applications/nrf_desktop/Kconfig.ble
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a help section paragraph to explain why this is needed
eba1066 to
54de8a9
Compare
|
Waiting for: nrfconnect/sdk-zephyr#3117 |
54de8a9 to
778d53b
Compare
|
Not needing FAST PAIR to turn on CONFIG_BT_ID_AUTO_SWAP_MATCHING_BONDS. |
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
778d53b to
5c5eec1
Compare
5c5eec1 to
820798f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment on PR #23631, if this change is for the 3.1.0 release, and remove the entry from this PR.
Also, add the backport label.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comment under #23631
Also removed changelog entry.
Added backport 3.1 label.
Allow bonding with the same HID host on multiple Bluetooth local identities. JIRA: NCSDK-32518 Signed-off-by: Jan Zyczkowski <[email protected]>
820798f to
0afef3c
Compare
Allow bonding with the same HID host on
multiple Bluetooth local identities.
JIRA: NCSDK-32518